New Bidder: Scalibur #4640

bTimor · 2025-12-21T14:31:25Z

Type of change

New bidder adapter

Description

This PR adds the Scalibur bidder adapter to Prebid Server.

Features:

Supports Banner and Video media types.
Implements User Sync via iframe.
Automated tests include standard unit tests and JSON data-driven samples.

Verification:

End-to-end user sync flow verified using a private Scalibur sync server.
Successfully verified that PBS maps the uids cookie to user.buyeruid in outgoing requests.
All tests in adapters/scalibur passed.
Root ./validate.sh passed (ignoring unrelated global config/hook test timeouts).

Checklist

I have performed a self-review of my code
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

adapters/scalibur/scalibur.go

github-actions · 2025-12-21T14:32:11Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a87ab09

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		93.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:170:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:257:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:282:	getBidMediaType		40.0%
total:									(statements)		82.7%

github-actions · 2025-12-22T09:36:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c4e7220

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

github-actions · 2025-12-22T12:20:30Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 088c807

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		40.0%
total:									(statements)		79.4%

github-actions · 2025-12-22T12:30:58Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 60a0c74

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:23:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:35:	MakeRequests		86.2%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:186:	MakeBids		71.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:273:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:298:	getBidMediaType		37.5%
total:									(statements)		78.4%

bTimor · 2025-12-23T08:26:40Z

I've updated the media type logic to follow the recommended pattern and resolved the bot feedback. Ready for review and workflow approval.

adapters/scalibur/scaliburtest/exemplary/success_banner.json

adapters/scalibur/scalibur.go

static/bidder-info/scalibur.yaml

static/bidder-params/scalibur.json

adapters/scalibur/scalibur.go

github-actions · 2026-01-12T09:12:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 09d4885

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:24:	Builder			71.4%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:40:	MakeRequests		84.7%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:196:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:284:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:309:	getBidMediaType		50.0%
total:									(statements)		82.6%

bTimor · 2026-01-12T09:26:48Z

@ccorbo
Updated the PR to address all feedback, including currency conversion, VAST extraction, and test file placement. Ready for another look.

adapters/scalibur/scalibur.go

static/bidder-info/scalibur.yaml

github-actions · 2026-01-14T09:12:37Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 98d3567

scalibur

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:24:	Builder			75.0%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:36:	MakeRequests		92.9%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:192:	MakeBids		92.1%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:284:	parseScaliburExt	77.8%
github.com/prebid/prebid-server/v3/adapters/scalibur/scalibur.go:309:	getBidMediaType		70.0%
total:									(statements)		89.7%

bTimor · 2026-01-14T09:12:58Z

Hi @ccorbo,

I've addressed the feedback from your review:

Code Improvements:
- Removed the redundant endpoint check in Builder as requested.
- Updated MakeBids to return a BadServerResponse error instead of silently skipping bids when an ImpID is not found or when the media type cannot be determined.
Enhanced Test Coverage:
- Added gpid.json to verify gpid preservation.
- Added debug.json and debug_prebid.json to cover both request.test == 1 and request.ext.prebid.debug == true scenarios.
- Added mtype.json to cover media type determination via bid.mtype.
- Added manual Go tests in scalibur_test.go (TestMakeBids_ImpNotFound and TestGetBidMediaType_Error) to specifically cover the new error paths.

All tests are passing. Let me know if there's anything else.
Thank you.

ccorbo

couple small things but overall lgtm, will approve after next changes

ccorbo · 2026-01-15T21:55:26Z

adapters/scalibur/scalibur.go

+	switch bid.MType {
+	case openrtb2.MarkupBanner:
+		return openrtb_ext.BidTypeBanner, nil
+	case openrtb2.MarkupVideo:


please add a test where you have a bid that returns a mtype for video, you also don't need audio / native in this switch statement as your adapter doesnt support those types.

ccorbo · 2026-01-15T21:55:46Z

adapters/scalibur/scalibur.go

+func parseScaliburExt(impExt json.RawMessage) (*openrtb_ext.ExtImpScalibur, error) {
+	var bidderExt adapters.ExtImpBidder
+	if err := jsonutil.Unmarshal(impExt, &bidderExt); err != nil {
+		return nil, &errortypes.BadInput{


tests for both error cases

Timor Bibi added 5 commits December 1, 2025 17:34

fresh

18b45e0

fix ortb and sync server support

9806d5d

finish scalibur prebid adapter

e20d4e9

Merge remote-tracking branch 'upstream/master' into scaliburA

952745d

Add Scalibur bid adapter with Banner, Video, and User Sync support

a87ab09

github-actions bot reviewed Dec 21, 2025

View reviewed changes

adapters/scalibur/scalibur.go Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 21, 2025

View reviewed changes

adapters/scalibur/scalibur.go Outdated Show resolved Hide resolved

add ext debug

c4e7220

add gzip compression support

088c807

resolve multi type response

60a0c74

bTimor mentioned this pull request Dec 28, 2025

[Update] Add Prebid Server support for Scalibur bidder prebid/prebid.github.io#6381

Open

4 tasks

ccorbo self-assigned this Jan 5, 2026

ccorbo reviewed Jan 5, 2026

View reviewed changes

adapters/scalibur/scalibur.go Outdated Show resolved Hide resolved

bsardo added the adapter label Jan 6, 2026

bsardo assigned pm-jaydeep-mohite Jan 12, 2026

Timor Bibi added 2 commits January 12, 2026 11:09

address PR review feedback and fix bidder implementation

8ae7336

Merge branch 'master' into scaliburA

09d4885

ccorbo reviewed Jan 13, 2026

View reviewed changes

static/bidder-info/scalibur.yaml Show resolved Hide resolved

ccorbo reviewed Jan 13, 2026

View reviewed changes

static/bidder-info/scalibur.yaml Show resolved Hide resolved

ccorbo reviewed Jan 13, 2026

View reviewed changes

static/bidder-info/scalibur.yaml Show resolved Hide resolved

address PR feedback for Scalibur adapter

98d3567

ccorbo reviewed Jan 15, 2026

View reviewed changes

New Bidder: Scalibur #4640

Are you sure you want to change the base?

New Bidder: Scalibur #4640

Uh oh!

Conversation

bTimor commented Dec 21, 2025

Type of change

Description

Features:

Verification:

Checklist

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 21, 2025

Code coverage summary

scalibur

Uh oh!

github-actions bot commented Dec 22, 2025

Code coverage summary

scalibur

Uh oh!

github-actions bot commented Dec 22, 2025

Code coverage summary

scalibur

Uh oh!

github-actions bot commented Dec 22, 2025

Code coverage summary

scalibur

Uh oh!

bTimor commented Dec 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 12, 2026

Code coverage summary

scalibur

Uh oh!

bTimor commented Jan 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2026

Code coverage summary

scalibur

Uh oh!

bTimor commented Jan 14, 2026

Uh oh!

ccorbo left a comment

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

ccorbo Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants